fix(ui): update util to allow matching the homepage as the active icon #15757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
121watts and
hoorayimhelping
and removed request for
a team
drdelambre
reviewed
Nov 5, 2019
TCL735
force-pushed
the
fix_15734_homepage_nav_icon_active
branch
from
ca5544f
to
0086763
Compare
drdelambre
approved these changes
Nov 5, 2019
hoorayimhelping
approved these changes
Nov 5, 2019
| true | ||
| ) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
❤️ love these tests!
only nit / style suggestion i could provide is: instead of using variables, just hard code the values in the test - it's a little more repetitive, but i find it makes the tests more explicit and it usually makes the intent of the test and the code a little easier to follow. again, a nit / suggestion, feel free to ignore.
expect(getNavItemActivation(['tokens'], `/orgs/3491cbaef55b4559////////tokens')).toEqual(true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15734