Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkger): add ability to supply a pkg from a url #16509

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Jan 12, 2020

the following is now possible from the CLI(same in REST API):
influx pkg -u https://gist.githubusercontent.com/jsteenb2/3a3b2b5fcbd6179b2494c2b54aa2feb0/raw/1717709ffadbeed5dfc88ff4cac5bf912c6930bf/bucket_pkg_json

one other small thing that mades it way in, noticed while testing the diff and sumary http responses have nulls for some of the slices. I want to normalize all those to provide [] if none are there. Guaranteeing no nulls.

Copy link
Contributor

@imogenkinsman imogenkinsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsteenb2 jsteenb2 merged commit fdc3e76 into master Jan 12, 2020
@jsteenb2 jsteenb2 deleted the pkger/from_url branch January 12, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants