Make show series return IDs and work with limit and offset. #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldix
force-pushed
the
show-series-updates
branch
2 times, most recently
from
2cd8f2c
to
4b3c650
Compare
|
|
||
| // Append the row to the result. | ||
| result.Series = append(result.Series, r) | ||
| } | ||
|
|
||
| if stmt.Limit > 0 { |
There was a problem hiding this comment.
should this be if stmt.Limt > 0 || stmt.Offset > 0 {?
|
Couple inline comments. Ohterwise, lgtm |
pauldix
force-pushed
the
show-series-updates
branch
from
099d044
to
a26f11f
Compare
pauldix
added a commit
that referenced
this pull request
Feb 27, 2015
Make show series return IDs and work with limit and offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.