Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(presentation-mode-notification): Triggers a notification when toggling dashboard presentation mode #18471

Merged
merged 5 commits into from Jun 11, 2020
Merged

fix(presentation-mode-notification): Triggers a notification when toggling dashboard presentation mode #18471

merged 5 commits into from Jun 11, 2020

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented Jun 11, 2020 •
edited

Closes #10772

Problem

The notification wasn't being dispatched

Solution

Updated the TS definition of what is being returned, dispatched the notification, and added an e2e test to ensure stability

presentation_mode_notification

  • CHANGELOG.md updated with a link to the PR (not the Issue)

@asalem1 asalem1 requested a review from drdelambre June 11, 2020 21:31
@asalem1 asalem1 merged commit a205c01 into master Jun 11, 2020
@asalem1 asalem1 deleted the fix/presentation-mode-notification branch June 11, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdelambre drdelambre drdelambre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification does not fire when user enters presentation mode
2 participants
@asalem1 @drdelambre