feat(cli): extend Program with config file #18568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
force-pushed
the
18565/cli_config_files
branch
from
fd7cb70
to
a393bb5
Compare
jsteenb2
commented
Jun 17, 2020
jsteenb2
force-pushed
the
18565/cli_config_files
branch
from
a393bb5
to
a581a6c
Compare
jsteenb2
commented
Jun 17, 2020
| // 2. env vars | ||
| // 3. config file | ||
| if err := initializeConfig(); err != nil { | ||
| panic(fmt.Sprintf("invalid config file[%s] caused panic: %s", configFile, err)) |
There was a problem hiding this comment.
the panic here is purposepul, if you provide a config, and it is janky, we're gonna explode
jsteenb2
force-pushed
the
18565/cli_config_files
branch
from
a581a6c
to
62f2a93
Compare
jsteenb2
force-pushed
the
18565/cli_config_files
branch
2 times, most recently
from
193d6b7
to
1c2cdb5
Compare
jsteenb2
force-pushed
the
18565/cli_config_files
branch
from
1c2cdb5
to
e25cf36
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the ability to provide a config file to Programs when using the
NewCommandconstructor 馃憤closes: #18565