Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): extend tests for CLI to capture how flags with - are in configs #18578

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

jsteenb2
Copy link
Contributor

the config for a daemon should use keys that match the flags of the
daemon it is provided too.

follow up to: #18568

Copy link
Contributor

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

Ship it!

… configs

the config for a daemon should use keys that match the flags of the
daemon it is provided too.
@jsteenb2 jsteenb2 force-pushed the chore/extend_cli_config_tests branch from 3782ff9 to 3fa5d99 Compare June 17, 2020 19:52
@jsteenb2 jsteenb2 merged commit ce6827c into master Jun 17, 2020
@jsteenb2 jsteenb2 deleted the chore/extend_cli_config_tests branch June 17, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants