Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup bucket auth and to transform dependencies #18820

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

GeorgeMac
Copy link
Contributor

@GeorgeMac GeorgeMac commented Jul 1, 2020

This is just a small clean-up PR.

  1. Tenant bucket auth middleware doesn't need a URM service (It doesn't use it). (doing this in another PR)
  2. The to() related pieces don't need to resolve a bucket or orgs name from an ID in order to function.

@GeorgeMac GeorgeMac changed the title Gm/remove to transform cruft chore: cleanup bucket auth and to transform dependencies Jul 1, 2020
@GeorgeMac GeorgeMac requested review from a team and stuartcarnie and removed request for a team July 1, 2020 09:07
@GeorgeMac GeorgeMac force-pushed the gm/remove-to-transform-cruft branch 3 times, most recently from 9d24ee6 to 50d70eb Compare July 1, 2020 16:17
Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖤 housekeeping like this

@GeorgeMac GeorgeMac force-pushed the gm/remove-to-transform-cruft branch from 50d70eb to e59c015 Compare July 16, 2020 11:48
@GeorgeMac GeorgeMac merged commit 4a845f6 into master Jul 24, 2020
@GeorgeMac GeorgeMac deleted the gm/remove-to-transform-cruft branch July 24, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants