fix(reduce-variable-hydration): filtering unused variables before hydrating them #18974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdelambre
suggested changes
Jul 17, 2020
…rs, need to add a test
Co-authored-by: Michael Desa <mjdesa@gmail.com>
asalem1
force-pushed
the
fix-hydrate-vars
branch
from
d5409d7
to
ccedb87
Compare
drdelambre
reviewed
Jul 17, 2020
ui/src/variables/actions/thunks.ts
Outdated
| } | ||
| return [] | ||
| } | ||
|
|
||
| // TODO: make this context aware |
drdelambre
approved these changes
Jul 17, 2020
There was a problem hiding this comment.
Note to self: this PR is about hydrateVariables which is different than hydrateVars. all of this extra mocking around the time machine is because of the selector we use to grab the current view when in data explorer mode (which does a bunch of stuff just to return the default view), which is currently the convention in our codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Over-hydrating variables whenever any queries are run
Solution
Filter out the unused variables before passing in the array of variables to update in order to reduce the graph dependencies that are ultimately returned and reduce the amount of queries that are performed in turn.