fix: restrict urm listing of a resource to members of org owning said resource #19251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lyondhill
commented
Aug 7, 2020
•
lyondhill
commented
- Well-formatted commit messages
- Rebased/mergeable
- Tests pass
lyondhill
requested review from
ebb-tide,
a team,
AlirieGray and
brettbuddin
and removed request for
a team and
AlirieGray
brettbuddin
reviewed
Aug 11, 2020
lyondhill
force-pushed
the
bugfix/e8141
branch
from
89aafad
to
5aca727
Compare
brettbuddin
approved these changes
Aug 11, 2020
lyondhill
force-pushed
the
bugfix/e8141
branch
from
5aca727
to
88976f4
Compare
brettbuddin
approved these changes
Aug 12, 2020
AlirieGray
approved these changes
Aug 12, 2020
Cubone21
pushed a commit
that referenced
this pull request
Aug 25, 2020
… resource (#19251) * fix: restrict urm listing of a resource to members of org owning said resource * chore: add testing around new urm behavior * fix: add feature flagging * fix: ensure we are returning the correct error Co-authored-by: greg linton <greg@influxdata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.