Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(task): Record last success and failure run times in the Task #19390

Merged
merged 5 commits into from Aug 25, 2020

Conversation

brettbuddin
Copy link
Contributor

@brettbuddin brettbuddin commented Aug 19, 2020

Part of influxdata/flux#3080

We currently record the following "last run" information on the Task record:

  • LatestCompleted (time)
  • LatestScheduled (time)
  • LastRunStatus (string)
  • LastRunError (string)

This change introduces two new timestamps that reflect the last success and failure times of a Task (respectively):

  • LatestSuccess (time)
  • LatestFailure (time)

With these timestamps we will be able to compose new APIs for the Task system to make time-gap resilient (in the face of an arbitrary number of Task failures) easier to write. The next step will be to inject this information into Tasks as they get handed off to the Query layer to be run.

@brettbuddin brettbuddin requested review from lyondhill and a team August 19, 2020 18:32
Copy link
Contributor

@gavincabbage gavincabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- your e2e failure seemed intermittent so I restarted

@adrian-thurston
Copy link
Contributor

Saw it got killed so I also restarted it, but same result.

ok  	github.com/influxdata/idpe/objectstore/metrics	1.030s
?   	github.com/influxdata/idpe/objectstore/mock	[no test files]
Killed
script returned exit code 137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants