Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(task): Inject Task's LatestSuccess Timestamp In Flux Extern #19402

Merged
merged 8 commits into from
Aug 25, 2020

Conversation

brettbuddin
Copy link
Contributor

@brettbuddin brettbuddin commented Aug 20, 2020

Part of influxdata/flux#3080
Continuation of #19390

Now that we're recording these timestamps, use them in the Task executor by injecting them as part of the Flux Extern. This sets the option tasks.latestSuccessTime = ... option on the query so that it can be used by some new APIs we're working on.

Will need to be rebased once #19390 is merged.

Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link
Contributor

@lyondhill lyondhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good.

@brettbuddin brettbuddin merged commit 1ae2541 into master Aug 25, 2020
@brettbuddin brettbuddin deleted the bb/task-extern branch August 25, 2020 17:06
wolffcm pushed a commit that referenced this pull request Sep 11, 2020
Inject Task's LatestSuccess Timestamp In Flux Extern (#19402)

* feat(task): Inject latest success/failure into extern.

* chore(task/backend): Don't specify an extern if there are no statements.

* chore(task/executor): Don't apply the latest failure for now.

* chore(changelog): Add 19402 to changelog.

* chore(kit): Introduce feature flag for time injection.

* chore(task/executor): Guard injection into extern by feature flag.

* chore(task/executor): No need for this subtest pattern.

* chore(task/executor): Add tests for extern injection.
wolffcm pushed a commit that referenced this pull request Sep 16, 2020
Inject Task's LatestSuccess Timestamp In Flux Extern (#19402)

* feat(task): Inject latest success/failure into extern.

* chore(task/backend): Don't specify an extern if there are no statements.

* chore(task/executor): Don't apply the latest failure for now.

* chore(changelog): Add 19402 to changelog.

* chore(kit): Introduce feature flag for time injection.

* chore(task/executor): Guard injection into extern by feature flag.

* chore(task/executor): No need for this subtest pattern.

* chore(task/executor): Add tests for extern injection.
@wolffcm wolffcm mentioned this pull request Sep 16, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants