Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to disable admin API #194

Closed
wants to merge 1 commit into from

Conversation

jvshahid
Copy link
Contributor

is there a way to completely disable the admin interface ?
if not is there a way to bind it to a specific ip address ?

@schmurfy
Copy link
Contributor Author

as a temporary solution omitting the admin table in configuration result in binding the server to port 0 which obviously fails ;)

@pauldix
Copy link
Member

pauldix commented Jan 21, 2014

Ah yes, this is definitely something we should support. Added to 0.5.0 milestone.

@ghost ghost assigned jvshahid Jan 24, 2014
@jvshahid jvshahid closed this in 25085e3 Jan 28, 2014
@schmurfy
Copy link
Contributor Author

why not simply consider that if the admin section is missing it should not be enabled ?

@jvshahid
Copy link
Contributor

I'm not clear what's your question, this issue was closed by a different change. You can see the end result here: https://github.com/influxdb/influxdb/blob/master/config.toml.sample#L17 Basically if the port isn't set then non-ssl binding is disabled. If ssl-port is not set then ssl binding is disabled. If the entire section is missing then the admin interface will be disabled.

@jvshahid
Copy link
Contributor

Actually I was talking about the api section, but the admin section has the same rules. If the port isn't set, binding doesn't take place.

@schmurfy
Copy link
Contributor Author

it answers my question then, I thought this changeset was the one closing the issue, that's... confusing xD

@jvshahid jvshahid deleted the fix-194-admin-api-enable-config branch January 31, 2014 20:43
jvshahid pushed a commit that referenced this pull request Aug 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants