fix: Disable unimplemented delete with predicate API #19636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more explicit that EInternal, allowing APIs to indicate a potentially temporary status of "501 Not implemented"
This commit removes incorrect implementations of the `DeleteBucket` and `DeleteBucketRangePredicate` APIs from the storage package, which remained after the transition to the tsdb 1.x storage engine. Secondly, this PR utilizes the `ENotImplemented` error code to inform users which call the `/api/v2/delete`
stuartcarnie
force-pushed
the
sgc/issue/19580
branch
from
5d15abe
to
4b1c54e
Compare
stuartcarnie
force-pushed
the
sgc/issue/19580
branch
from
4b1c54e
to
c1c0168
Compare
brettbuddin
approved these changes
Sep 24, 2020
bednar
added a commit
to influxdata/influxdb-client-java
that referenced
this pull request
Sep 30, 2020
bednar
added a commit
to influxdata/influxdb-client-csharp
that referenced
this pull request
Oct 1, 2020
…between beta and nightly (influxdata/influxdb#19636)
4 tasks
bednar
added a commit
to influxdata/influxdb-client-csharp
that referenced
this pull request
Oct 1, 2020
- compatibility tests between beta and nightly (influxdata/influxdb#19636)
bednar
added a commit
to influxdata/influxdb-client-python
that referenced
this pull request
Oct 1, 2020
… between beta and nightly (influxdata/influxdb#19636)
4 tasks
bednar
added a commit
to influxdata/influxdb-client-python
that referenced
this pull request
Oct 1, 2020
… between beta and nightly (influxdata/influxdb#19636) (#159)
bednar
added a commit
to influxdata/influxdb-client-ruby
that referenced
this pull request
Oct 1, 2020
… between beta and nightly (influxdata/influxdb#19636)
4 tasks
bednar
added a commit
to influxdata/influxdb-client-ruby
that referenced
this pull request
Oct 1, 2020
… between beta and nightly (influxdata/influxdb#19636) (#54)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19580
This PR disables the
/api/v2/deleteAPI and returns a501 Not implemented, as there is no available implementation of the feature via the 1.xtsdbstorage engine. Follow up issue #19635 was created to track the future implementation of this functionality.