Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable /api/v2/delete #19580

Closed
1 task done
stuartcarnie opened this issue Sep 17, 2020 · 0 comments · Fixed by #19636
Closed
1 task done

Disable /api/v2/delete #19580

stuartcarnie opened this issue Sep 17, 2020 · 0 comments · Fixed by #19636
Assignees
@stuartcarnie
Labels
area/2.x OSS 2.0 related issues and PRs team/compute team/storage

Comments

@stuartcarnie
Copy link
Contributor

stuartcarnie commented Sep 17, 2020 •
edited
Loading

What

The HTTP API /api/v2/delete is incomplete after the TSM1.x transition. There is a risk that by not passing sources or the predicate to the storage engine, it may result in catastrophic data loss:

influxdb/storage/engine.go

Line 324 in 8576d1d

// TODO - edd convert the predicate into an influxql.Expr

  • Update the HTTP handler to return 501 Not Implemented until the feature is can be supported by the tsdb storage engine.
@stuartcarnie stuartcarnie added area/2.x OSS 2.0 related issues and PRs team/compute team/storage labels Sep 17, 2020
@stuartcarnie stuartcarnie changed the title DeleteBucketRangePredicate ignores the predicate, deleting all /api/v2/delete may result in unexpected data loss Sep 17, 2020
@stuartcarnie stuartcarnie changed the title /api/v2/delete may result in unexpected data loss Disable /api/v2/delete Sep 24, 2020
@stuartcarnie stuartcarnie self-assigned this Sep 24, 2020
This was referenced Sep 24, 2020
Closed
Merged
randycoulman pushed a commit to influxdata/telemetry_influxdb that referenced this issue Oct 20, 2020
feat: Upgrade to influx 2.0-rc
c4dcd14 
The tests are currently failing due to the removal of the delete-with-predictate API.

It was removed in influxdata/influxdb#19580 and there is an open issue for restoring it in influxdata/influxdb#19635.
randycoulman pushed a commit to influxdata/telemetry_influxdb that referenced this issue Oct 22, 2020
feat: Upgrade to influx 2.0-rc
14b880c 
The tests are currently failing due to the removal of the delete-with-predictate API.

It was removed in influxdata/influxdb#19580 and there is an open issue for restoring it in influxdata/influxdb#19635.
This was referenced Oct 22, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartcarnie stuartcarnie

Labels
area/2.x OSS 2.0 related issues and PRs team/compute team/storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Disable unimplemented delete with predicate API influxdata/influxdb
2 participants
@stuartcarnie and others