fix: make tagKeys and tagValues work for edge cases involving _field #19856
Conversation
wolffcm
force-pushed
the
fix/tag-values-tag-keys
branch
from
59dd302
to
84a3638
Compare
|
I had to re-skip the Flux test The tip of Flux master has more tests (all of which pass against this branch), and also fixes this issue with the test. I made a note for myself to unskip this test after Flux has upgraded on Monday. |
wolffcm
force-pushed
the
fix/tag-values-tag-keys
branch
from
e729af3
to
8fce8f4
Compare
There was a problem hiding this comment.
Looks great to me, @wolffcm – I had one suggestion to improve a struct iteration, as I've seen these loops show up in profiles in the past. Happy to skip the change in this PR and we can address it in a subsequent update if it shows up in profiles.
| // tagValuesSlow will determine the tag values for the given tagKey. | ||
| // It's generally faster to use tagValues, measurementFields or | ||
| // MeasurementNames, but those methods will only use the index and metadata | ||
| // stored in the shard. Because fields are not themselves indexed, we have no way | ||
| // of correlating fields to tag values, so we sometimes need to consult tsm to | ||
| // provide an accurate answer. |
There was a problem hiding this comment.
Appreciate the detailed comment 👍
Fixes #19806
Fixes #19794
This updates the
tagKeysandtagValuesmethods of theStoreinterface to return the answers that Flux is used to, by properly filtering on_fieldwhen such a predicate is present. These methods are frequently used by the UI query builder to describe the shape of the users data.