fix: make influxd help more specific #19939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Nov 9, 2020
| @@ -121,7 +121,7 @@ func NewInfluxdCommand(ctx context.Context, subCommands ...*cobra.Command) *cobr | |||
|
|
|||
| A config file can be provided via the INFLUXD_CONFIG_PATH env var. If a file is | |||
| not provided via an env var, influxd will look in the current directory for a | |||
| config.yaml file. If one does not exist, then it will continue unchanged.` | |||
| config.{json|toml|yaml|yml} file. If one does not exist, then it will continue unchanged.` | |||
There was a problem hiding this comment.
I'm not sure if this is the best way to explain that any of these extensions are valid
dgnorton
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19929
The help text for
influxdsays thatconfig.yamlwill be used as a default, if found. As far as I can tell from reading this, the CLI will actually find any ofconfig.{json|toml|yaml|yml}.