refactor(cmd/influxd): parse log-level CLI opts directly to correct type #20196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Nov 30, 2020
| "go.uber.org/zap/zapcore" | ||
| ) | ||
|
|
||
| type levelValue zapcore.Level |
There was a problem hiding this comment.
This boilerplate file is pretty much identical to kit/cli/idflag.go, but with zapcore.Level instead of influxdb.ID.
| } | ||
| if s := v.GetString(envVar); s != "" { | ||
| _ = (*destP).Set(v.GetString(envVar)) | ||
| } |
There was a problem hiding this comment.
This block is mostly boilerplate, following the same pattern as the preceding cases
davidby-influx
approved these changes
Nov 30, 2020
| "go.uber.org/zap/zapcore" | ||
| ) | ||
|
|
||
| type levelValue zapcore.Level |
There was a problem hiding this comment.
Is this definition just a way to declare methods on the zapcore.Level type? Nice trick!
There was a problem hiding this comment.
(I think) yes, specifically so we can redefine methods like String and Set that already exist on the zapcore.Level type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19976
This took more boilerplate than I expected, I could be convinced it's not worth the trouble.