Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: refactor influxd's "run" method for better readability / testability #19976

Open
danxmoran opened this issue Nov 10, 2020 · 0 comments
Open

Tech debt: refactor influxd's "run" method for better readability / testability #19976

danxmoran opened this issue Nov 10, 2020 · 0 comments
Labels
area/2.x OSS 2.0 related issues and PRs kind/tech-debt Needs cleanup, will make the developer experience better

Comments

@danxmoran
Copy link
Contributor

influxd's run method is ~800 lines long. This makes it very hard to tell how different pieces of the DB interact with and depend on one another during setup, especially when using middleware that doesn't affect types (i.e. applying an authorization wrapper).

It should be possible to refactor run into smaller pieces and make it easier to understand.
@danxmoran danxmoran added kind/tech-debt Needs cleanup, will make the developer experience better area/2.x OSS 2.0 related issues and PRs labels Nov 10, 2020
@danxmoran danxmoran self-assigned this Nov 18, 2020
@danxmoran danxmoran mentioned this issue Nov 19, 2020
Merged
8 tasks
This was referenced Nov 30, 2020
Merged
Closed
This was referenced Dec 16, 2020
Merged
Merged
@danxmoran danxmoran removed their assignment Dec 23, 2020
@danxmoran danxmoran self-assigned this Jan 14, 2021
@danxmoran danxmoran mentioned this issue Aug 30, 2021
Merged
@danxmoran danxmoran removed their assignment Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/2.x OSS 2.0 related issues and PRs kind/tech-debt Needs cleanup, will make the developer experience better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danxmoran