fix: don't use a finished context for graceful shutdown #20355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Dec 16, 2020
danxmoran
commented
Dec 16, 2020
davidby-influx
requested changes
Dec 16, 2020
davidby-influx
approved these changes
Dec 16, 2020
danxmoran
force-pushed
the
dm-graceful-shutdown-ctx-fix
branch
from
1b76842
to
d1675f3
Compare
ayang64
reviewed
Feb 9, 2021
| if err := l.run(ctx, o); err != nil { | ||
|
|
||
| // Start the launcher and wait for it to exit on SIGINT or SIGTERM. | ||
| runCtx := signals.WithStandardSignals(ctx) |
There was a problem hiding this comment.
why assign this to runCtx and not simply:
ctx = signals.WithStandardSignals(ctx)
also, if you're using go 1.15, i think you can use os/signal.NotifyContext().
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19976
Ayan noticed in a separate PR that we were misusing
ctxvalues here, resulting in an immediate timeout of our graceful-shutdown code. Splitting out the fix to make it easy to review.