Fixing intervals for group by. #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
influxdb-denver-pair
changed the title
| @@ -13,6 +13,7 @@ | |||
| - [#2040](https://github.com/influxdb/influxdb/pull/2040): Add missing top-level help for config command. | |||
| - [#2057](https://github.com/influxdb/influxdb/pull/2057): Move racy "in order" test to integration test suite. | |||
| - [#2060](https://github.com/influxdb/influxdb/pull/2060): Reload server shard map on restart. | |||
| - [#2067](https://github.com/influxdb/influxdb/pull/2067): Fixing intervals for group by. | |||
There was a problem hiding this comment.
Nit: Capitalize GROUP BY for readability in the CHANGELOG.
corylanou
force-pushed
the
relative-times-off-2045
branch
from
d163ba8
to
84a9b8a
Compare
pauldix
added a commit
that referenced
this pull request
Mar 25, 2015
Fixing intervals for group by.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously accepted a PR that broke the interval buckets for group by.
Effectively, if you asked for a group by
10s, and started your time query on a05second interval, the buckets didn't calculate properly.The issue though, was real, so we created the proper fix for this PR that we also reverted at the same time: #2016
Also fixes Issue #2045