feat(http): add config option to disable metrics endpoint in influxd #20963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
force-pushed
the
dm-disable-metrics-http-20755
branch
from
2689c32
to
aae02dd
Compare
|
what happens if someone does |
The |
lesam
reviewed
Mar 15, 2021
| @@ -68,34 +83,23 @@ func WithPprofEnabled(enabled bool) HandlerOptFn { | |||
| } | |||
| } | |||
|
|
|||
| func WithHealthHandler(h http.Handler) HandlerOptFn { | |||
There was a problem hiding this comment.
Why are we dropping the health and ready handler code? They're just not called?
danxmoran
force-pushed
the
dm-disable-metrics-http-20755
branch
from
aae02dd
to
561052a
Compare
lesam
reviewed
Mar 15, 2021
http/handler_test.go
Outdated
| w: httptest.NewRecorder(), | ||
| }, | ||
| { | ||
| name: "should record metrics when http handling", |
There was a problem hiding this comment.
nitpick: test name should be different?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20755
NOTE: We wire up the
influxdprocess with aprom.Registryeven when/metricsis disabled, because the metrics are also used by our telemetry reporter. A follow-up improvement could avoid all the prometheus code paths when both metrics and reporting are disabled.