Distributed Queries #2202
Merged
Distributed Queries #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
distributed-queries-m
branch
2 times, most recently
from
4a39dd6
to
dbd33b7
Compare
otoolep
force-pushed
the
distributed-queries-m
branch
4 times, most recently
from
40b6866
to
2abe5b3
Compare
Refactored query engine to have different processing pipeline for raw queries. This enables queries that have a large offset to not keep everything in memory. It also makes it so that queries against raw data that have a limit will only p rocess up to that limit and then bail out. Raw data queries will only read up to a certain point in the map phase before yielding to the engine for further processing. Fixes #2029 and fixes #2030
Fixes issue #1649
otoolep
force-pushed
the
distributed-queries-m
branch
from
b1a4df1
to
b461a36
Compare
No doubt about it, URL routing is definitely brittle and needs work.
With a max remote reponse of 1GB, testing is unable to proceed.
otoolep
force-pushed
the
distributed-queries-m
branch
from
b461a36
to
5882f0b
Compare
| } | ||
|
|
||
| // request to start streaming results | ||
| resp, err := http.Post(m.dataNodes[0].URL.String()+"/run_mapper", "application/json", bytes.NewReader(b)) |
There was a problem hiding this comment.
Should this be m.dataNode[rand.Intn(len(m.dataNodes))]to avoid a single node handling all the traffic? Or is m.dataNodes already randomized beforehand?
There was a problem hiding this comment.
I was thinking exactly the same thing myself.
|
Two comments but LGTM otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.