Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more expressive errors #22612

Merged
merged 2 commits into from
Oct 4, 2021
Merged

fix: more expressive errors #22612

merged 2 commits into from
Oct 4, 2021

Conversation

lesam
Copy link
Contributor

@lesam lesam commented Oct 4, 2021 •
edited

Closes #22449

@lesam lesam requested a review from danxmoran October 4, 2021 15:02
danxmoran
danxmoran approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall but needs some import cleanup

http/errors_test.go Outdated
@@ -4,6 +4,7 @@ import (
"context"
"encoding/json"
stderrors "errors"
"go.uber.org/zap/zaptest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs reformatted?

http/legacy/influx1x_authentication_handler_test.go Outdated
@@ -3,6 +3,7 @@ package legacy
import (
"context"
"fmt"
"go.uber.org/zap/zaptest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

http/legacy/write_handler_test.go Outdated
@@ -3,6 +3,7 @@ package legacy
import (
"context"
"fmt"
"go.uber.org/zap"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

kit/transport/http/error_handler.go Outdated
@@ -6,6 +6,7 @@ import (
"encoding/json"
"errors"
"fmt"
"go.uber.org/zap"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

kit/transport/http/error_handler_test.go Outdated
@@ -3,6 +3,7 @@ package http_test
import (
"context"
"fmt"
"go.uber.org/zap/zaptest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one

@lesam
Copy link
Contributor Author

lesam commented Oct 4, 2021

Ideally we'd run the formatting we want in the linter... gci is pretty good.

@lesam lesam merged commit 2985796 into influxdata:2.0 Oct 4, 2021
@williamhbaker williamhbaker mentioned this pull request Oct 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxmoran danxmoran danxmoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lesam @danxmoran