Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: initialized CHANGELOG_OLD.md with initial changes for this release branch #22729

Merged
merged 2 commits into from Oct 21, 2021

Conversation

williamhbaker
Copy link
Contributor

Related to #22716

This creates an initial changelog file for the 2.1 release branch. Since our changelog automation is not yet capable of generating the first changelog for a release branch, I did it manually by reviewing the commit history on master and 2.0. This is the file we will actually include with the release.

To generate this new changelog, I started from the CHANGELOG_OLD file on the master branch and:

  • Deleted all of the sections for previous releases: 2.0.8, 2.0.7, etc. Only the "unreleased" section was kept.
  • Reviewed the release notes for the v2.0.9 release and removed all of the changes listed there.
  • Starting from commit 824e76c which is where the changelog automation began and we generally stopped manually adding changelog entries, I went through all the commits in the 2.1 branch and selected anything that was a fix or a feat, + the latest flux upgrade which is a build. Any of these that were not included with the 2.0.9 release were added.

Some of the feat commits represent partial implementations of a feature (for example, many commits are related to replications). These do not have any user-facing impact and I did not include them.

For reference, this is a chronological list of commits (oldest on top) tagged as either fix or feat on the 2.1 branch since commit 824e76c, along with their categorization per the above process:

1. [21367](https://github.com/influxdata/influxdb/pull/21367): List users via the API now supports pagination
1. [21531](https://github.com/influxdata/influxdb/pull/21531): Remove feature flags for permanent UI features
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these feature flags were all "on" by default, this change does not have a user impact.

CHANGELOG_OLD.md Outdated Show resolved Hide resolved
@williamhbaker williamhbaker marked this pull request as ready for review October 21, 2021 19:34
CHANGELOG_OLD.md Outdated
@@ -32,1447 +24,50 @@ This release adds an embedded SQLite database for storing metadata required by t

### Features

1. [19811](https://github.com/influxdata/influxdb/pull/19811): Add Geo graph type to be able to store in Dashboard cells.
1. [21218](https://github.com/influxdata/influxdb/pull/21218): Add the properties of a static legend for line graphs and band plots.
1. [19811](https://github.com/influxdata/influxdb/pull/19811): Add Geo graph type to be able to store in Dashboard cells
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we omit this since we ended up deciding not to add Geo support to OSS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes sense. Removed!

CHANGELOG_OLD.md Outdated Show resolved Hide resolved
CHANGELOG_OLD.md Outdated
1. [21648](https://github.com/influxdata/influxdb/pull/21648): Change static legend's `hide` to `show` to let users decide if they want it
1. [22442](https://github.com/influxdata/influxdb/pull/22442): Detect noninteractive prompt when displaying warning in `buildtsi`
1. [22458](https://github.com/influxdata/influxdb/pull/22458): Ensure files are closed before they are deleted or moved in `deletetsm`
1. [22448](https://github.com/influxdata/influxdb/pull/22448): More expressive errors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we elaborate on this? Or are we trying to be strict about CHANGELOG entry == commit message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expanded on the description to be more clear. No need to match commit messages right now.

1. [22442](https://github.com/influxdata/influxdb/pull/22442): Detect noninteractive prompt when displaying warning in `buildtsi`
1. [22458](https://github.com/influxdata/influxdb/pull/22458): Ensure files are closed before they are deleted or moved in `deletetsm`
1. [22448](https://github.com/influxdata/influxdb/pull/22448): More expressive errors
1. [22545](https://github.com/influxdata/influxdb/pull/22545): Sync series segment to disk after writing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: I think this might have been reverted in the 1.x line, @DStrand1 might know

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was reverted on the 1.9 branch: #22605

Sounds like that was for the 1.9.5 release and it will be back in for later releases. The change is still exists in master-1.x.

@williamhbaker williamhbaker merged commit 017acde into 2.1 Oct 21, 2021
@williamhbaker williamhbaker deleted the wb-update-2.1-changelog branch October 21, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants