fix: improve delete speed when a measurement is part of the predicate #23786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidby-influx
requested changes
Oct 13, 2022
davidby-influx
requested changes
Oct 14, 2022
tsdb/store.go
Outdated
| @@ -6,6 +6,7 @@ import ( | |||
| "context" | |||
| "errors" | |||
| "fmt" | |||
| errors3 "github.com/influxdata/influxdb/v2/pkg/errors" | |||
There was a problem hiding this comment.
errors3 should be in a separate import block following the standard Go packages.
There was a problem hiding this comment.
Turns out GoLand was set to gofmt import style rather than goimports. Seems a violation of Go's whole ethos to have 2 different formatting styles.
There was a problem hiding this comment.
Been bitten by that many times....
davidby-influx
requested changes
Oct 14, 2022
| @@ -16,6 +15,8 @@ import ( | |||
| "sync" | |||
| "time" | |||
|
|
|||
| errors3 "github.com/influxdata/influxdb/v2/pkg/errors" | |||
There was a problem hiding this comment.
I thhink errors3 should be in the block below, not a separate block.
There was a problem hiding this comment.
It passed the lint stage (and my formatting once I set the right style), so I think this is right
davidby-influx
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current delete statement does not take into account the measurement predicate. It will blindly loop through all the measurements in each shard and run the delete. This can be very slow on instances with a lot of measurements. This change checks for measurement existence, and if found, only runs the delete on that measurement.
Context
The value add is faster deletes that have a measurement predicate.
Note for reviewers:
Check the semantic commit type: