Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve delete speed when a measurement is part of the predicate #23786

Merged
merged 4 commits into from
Oct 14, 2022
Merged

fix: improve delete speed when a measurement is part of the predicate #23786

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
042ff49
fix: improve delete speed when a measurement is part of the predicate
jeffreyssmith2nd Oct 7, 2022
d7bc1a6
test: add test for deleting measurement by predicate
jeffreyssmith2nd Oct 12, 2022
0c4a344
chore: improve error messaging and capturing
jeffreyssmith2nd Oct 14, 2022
d37f577
chore: set goland to use the right formatting style
jeffreyssmith2nd Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tsdb/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"context"
"errors"
"fmt"
errors3 "github.com/influxdata/influxdb/v2/pkg/errors"
"io"
"os"
"path/filepath"
Expand All @@ -16,6 +15,8 @@ import (
"sync"
"time"

errors3 "github.com/influxdata/influxdb/v2/pkg/errors"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thhink errors3 should be in the block below, not a separate block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passed the lint stage (and my formatting once I set the right style), so I think this is right

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird.


"github.com/influxdata/influxdb/v2"
"github.com/influxdata/influxdb/v2/influxql/query"
errors2 "github.com/influxdata/influxdb/v2/kit/platform/errors"
Expand Down