Track more stats and report errors for shards #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylanou
force-pushed
the
snapshot-backup-err-loggin
branch
from
cd64512
to
b922cdc
Compare
|
👍 this is awesome! |
toddboom
added a commit
that referenced
this pull request
Apr 23, 2015
Track more stats and report errors for shards
| @@ -1188,6 +1188,8 @@ func (s *Server) applyCreateShardGroupIfNotExists(m *messaging.Message) (err err | |||
| // Generate an ID for each shard. | |||
| for _, sh := range g.Shards { | |||
| sh.ID = tx.nextShardID() | |||
| sh.stats = NewStats(fmt.Sprintf("shard %d", sh.ID)) | |||
| sh.stats.Inc("create") | |||
There was a problem hiding this comment.
Why store this statistic? A shard is created once. Why store it?
There was a problem hiding this comment.
This is only for debugging. We have an issue where the shard store is closed, and I need to find out if it's shards we open from disk, or create from memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.