Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Flush() for httpd.responseLogger #2465

Merged
merged 1 commit into from
May 1, 2015

Conversation

Jackkoz
Copy link
Contributor

@Jackkoz Jackkoz commented Apr 30, 2015

This pull request is a solution to issue "Empty respones from server when using chunked responses" that I have reported myself. It is a simple implementation of a missing method in httpd.responseLogger.

@Jackkoz
Copy link
Contributor Author

Jackkoz commented Apr 30, 2015

Link to the mentioned issue: #2466

@otoolep
Copy link
Contributor

otoolep commented Apr 30, 2015

Thanks @Jackkoz -- can you please sign the CLA?

http://influxdb.com/community/cla.html

@Jackkoz
Copy link
Contributor Author

Jackkoz commented Apr 30, 2015

@otoolep - I've just signed it.

@otoolep
Copy link
Contributor

otoolep commented Apr 30, 2015

Thanks @Jackkoz -- I have confirmed that the issue exists, and that this change fixes it.

@otoolep
Copy link
Contributor

otoolep commented Apr 30, 2015

@corylanou

We do have a chunked query test here, but it's obviously not checking all behaviour.

https://github.com/influxdb/influxdb/blob/master/httpd/handler_test.go#L1658

@corylanou
Copy link
Contributor

@otoolep I was just looking through tests for that exact thing :-). We should just open an issue to enhance that test to check for this if we want to close this. I agree this is a bug and the fix is correct.

+1

@otoolep
Copy link
Contributor

otoolep commented Apr 30, 2015

I am digging into the code now -- what is about the code path the tests take that don't catch this?

@Jackkoz
Copy link
Contributor Author

Jackkoz commented May 1, 2015

Have you tried checking if the tests turn off logging or use gzipped responses?

@otoolep
Copy link
Contributor

otoolep commented May 1, 2015

We'll need to look into the testing, but merging this now.

otoolep added a commit that referenced this pull request May 1, 2015
Implemented Flush() for httpd.responseLogger
@otoolep otoolep merged commit 68a323d into influxdata:master May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants