Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster config fixes and removal of meta.peers config field #3638

Merged
merged 4 commits into from
Aug 12, 2015
Merged

Cluster config fixes and removal of meta.peers config field #3638

merged 4 commits into from
Aug 12, 2015

Commits on Aug 12, 2015

  1. Make sure port is optional when passing hostanme flag

    @jwilder
    jwilder committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    f07b8d4 View commit details
    Browse the repository at this point in the history

  2. Fix panic: reflect: call of reflect.Value.NumField on string Value 

    The env var overrides panic if we if peers was set in the config.
The type of that value is a []string and NumFields is not a valid
for that type.  We don't currently support this slice fields via
the env variable settings.  This particular one can be set with the
-join flag already so we just skip these fields for now.
    @jwilder
    jwilder committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    5dfd252 View commit details
    Browse the repository at this point in the history

  3. Remove [meta].peers config option 

    Adding a new peer must happen via the -join flag.
    @jwilder
    jwilder committed Aug 12, 2015
    2 Configuration menu
    Copy the full SHA
    17583f7 View commit details
    Browse the repository at this point in the history

  4. Update changelog

    @jwilder
    jwilder committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    e8f8ab9 View commit details
    Browse the repository at this point in the history