We shouldn't send requests or responses that are larger than MAX_REQUEST_SIZE

[jvshahid]

There's no point from rejecting a request or response on the receiving end. If we need to limit the request or response then we need to split those requests and responses.

Why do we need MAX_REQUEST_SIZE and MAX_RESPONSE_SIZE anyway ?

[jvshahid]

@pauldix brought to my attention that this is already fixed for responses. We currently split the response points in half if the message exceeds the MAX_RESPONSE_SIZE until the message is smaller than the MAX_RESPONSE_SIZE. We still need two things:

1. Do the same thing for requests
2. Handle Multiple series in requests and responses
3. Use protobuf MessageSize() instead of encoding the response/request to determine the length of the serialized message
4. Leave the checks in case there's a cluster with old and new nodes (for now)

To answer the questions mentioned in the issue description. We're limiting the size of the request and response because we're reusing the read and write buffer which has a fixed size of MAX_xxx so we don't keep reallocating memory over and over.

[jvshahid]

one more thing that i just noticed, what happens if a response is split and the number of responses exceeds the response channel size ?

[pauldix]

This looks beautiful. I commend you, @jvshahid.