Changes to make the cluster sub package golint-able #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Enable golint on the code base influxdata#4098
| @@ -16,12 +16,22 @@ type MapShardRequest struct { | |||
| pb internal.MapShardRequest | |||
| } | |||
|
|
|||
| func (m *MapShardRequest) ShardID() uint64 { return m.pb.GetShardID() } | |||
| func (m *MapShardRequest) Query() string { return m.pb.GetQuery() } | |||
| // ShardID of the storage | |||
There was a problem hiding this comment.
Isn't this the shard ID of the map request?
|
Thanks @lenko-d -- have you signed the CLA? |
Issue: Enable golint on the code base influxdata#4098 (changes only for the cluster subpackage) - [ ] CHANGELOG.md updated - [X] Rebased/mergable - [X] Tests pass - [X] Sign [CLA](http://influxdb.com/community/cla.html) (if not already signed)
|
I fixed the comments. Please review. CLA signed. |
|
Looks good @lenko-d -- thanks. Comments only, confirmed CLA signed, merging now. |
otoolep
added a commit
that referenced
this pull request
Sep 29, 2015
Changes to make the cluster sub package golint-able
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Enable golint on the code base #4098