Added IF EXISTS for DROP DATABASE command, #4659 #4698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch33hau
force-pushed
the
drop-database-if-exists
branch
from
eb48200
to
e3d2edb
Compare
| @@ -369,6 +369,8 @@ func (q *QueryExecutor) executeDropDatabaseStatement(stmt *influxql.DropDatabase | |||
| dbi, err := q.MetaStore.Database(stmt.Name) | |||
| if err != nil { | |||
| return &influxql.Result{Err: err} | |||
| } else if dbi == nil && stmt.IfExists { | |||
There was a problem hiding this comment.
Minor, but I think better style would be:
} else if dbi == nil {
if stmt.IfExists {
return &influxql.Result{}
}
return &influxql.Result{Err: ErrDatabaseNotFound(stmt.Name)}
}
There was a problem hiding this comment.
Hi @otoolep , Thanks for your suggestion, I have updated it.
|
Thanks @ch33hau -- looks great. I have some small feedback before we merge. @dgnorton @corylanou -- can I get a second review? |
|
Looks good. +1 |
ch33hau
force-pushed
the
drop-database-if-exists
branch
from
e3d2edb
to
2235dce
Compare
otoolep
added a commit
that referenced
this pull request
Nov 7, 2015
Added IF EXISTS for DROP DATABASE command, #4659
|
Thanks @otoolep @corylanou =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Can I create a pull request for this issue? #4659
Thanks