fix issue #5054 #5064
Merged
fix issue #5054 #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengjinglei
force-pushed
the
fix-parens-math
branch
from
31b677f
to
3a901ab
Compare
| @@ -808,6 +808,11 @@ func TestServer_Query_Math(t *testing.T) { | |||
| command: `SELECT max(value) + min(value) from db.rp.integer`, | |||
| exp: fmt.Sprintf(`{"results":[{"series":[{"name":"integer","columns":["time",""],"values":[["1970-01-01T00:00:00Z",84]]}]}]}`), | |||
| }, | |||
| &Query{ | |||
| name: "SELECT square of enclosed integer value", | |||
| command: `SELECT ((value) * (value)) from db.rp.integer`, | |||
There was a problem hiding this comment.
Why have you wrapped value individual in parenthesis? Just to fully test the code? If so, I'd prefer the following tests, so it's clearer:
SELECT ((value) * (value))
SELECT (value * value)
There was a problem hiding this comment.
OK，add a test case according to the comment
|
+1, thanks @mengjinglei |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #5054