Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHOW FIELD shouldn't expect VALUES. #5178

Merged
merged 1 commit into from
Dec 21, 2015
Merged

SHOW FIELD shouldn't expect VALUES. #5178

merged 1 commit into from
Dec 21, 2015

Conversation

pires
Copy link
Contributor

@pires pires commented Dec 20, 2015

  • CHANGELOG.md updated
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Fixes #5176

@otoolep
Copy link
Contributor

otoolep commented Dec 20, 2015

Any chance we could add a test for this? Is that possible?

@pires
Copy link
Contributor Author

pires commented Dec 20, 2015

There are tests for SHOW FIELD KEYS. SHOW FIELD VALUES seems to not be valid at all, and the reason why it's there is unknown to me. I assumed it was supposed to be removed anyway.

@otoolep
Copy link
Contributor

otoolep commented Dec 20, 2015

Ah, I see. I had it backwards.

On Sunday, December 20, 2015, Paulo Pires notifications@github.com wrote:

There are tests for SHOW FIELD KEYS. SHOW FIELD VALUES seems to not be
valid at all, and the reason why it's there is unknown to me. I assumed it
was supposed to be removed anyway.


Reply to this email directly or view it on GitHub
#5178 (comment).

@pires
Copy link
Contributor Author

pires commented Dec 21, 2015

@beckettsean what do you think then about the proposed fix?

@beckettsean
Copy link
Contributor

@pires looks good to me, but I'm not qualified to vet Go code.

@otoolep
Copy link
Contributor

otoolep commented Dec 21, 2015

+1

@dgnorton ?

@dgnorton
Copy link
Contributor

+1 Thanks, @pires !

otoolep added a commit that referenced this pull request Dec 21, 2015
SHOW FIELD shouldn't expect VALUES.
@otoolep otoolep merged commit cc28b9a into influxdata:master Dec 21, 2015
@pires pires deleted the 5176_show_field branch December 22, 2015 00:01
@jwilder jwilder added this to the 0.10.0 milestone Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants