Cluster Setup #5706
Merged
Cluster Setup #5706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1251,6 +1258,14 @@ func (e errRedirect) Error() string { | |||
| return fmt.Sprintf("redirect to %s", e.host) | |||
| } | |||
|
|
|||
| type errCommand struct { | |||
There was a problem hiding this comment.
Is there a reason to make thing a struct instead of just an aliased type? type errCommand string
There was a problem hiding this comment.
No particular reason other than the error above did it this way: #5706 (diff)
|
Small nit but LGTM 👍
|
This fixes several issues related to the bind address and hostname: * Allows bind addresses where a hostname or IP is not specified to work correct and bind to all interfaces by default. * Fixes the top-level "hostname" config option to allow overridding all bind address hostnames. This allows a node to advertise a different hostname than what is defined in the bind address setting. * Adds the -hostname command-line option back to allow specifing both -join and -hostname as command-line flags. * Enforces a configuration precedence and overriding ability defined as config file is overridden by env vars which are overriden by command-line flags. Fixes #5670 #5671
Dropping a meta node that had already been removed from the config would fail because the raft.RemovePeers call would return an error that the address was unknown. This change skips calling RemovePeer if it doesn't exist. Dropping a non-existing ID would hang for 10 seconds becuase the meta.Client retryUntilExec didn't differentiate before command errors and redirect errors. In this case, the command would return an error but we'd try 10 more times and ultimately give up and return the error. We now return immediately if the command returned and error because retrying it will not succeed. Finally, the join loop had no delay and would immediately try to join the other nodes hundreds of times a second. We now pause a second if we've tried every node at least once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses most of the issues from #5673. Specifically, it changes the following:
bind-address = ":8088"will now bind to all interfaces instead of justlocalhost.hostnameconfig option to allow overriding all bind address hostnames. This allows a node to advertise a different hostname than what is defined in the bind address setting. For example, if the config isbind-address = ":8088"andhostname = "influx1", the node will bind to all interfaces on port8088and remote nodes will reach this node using the addressinflux1:8088. If ahostnameis not specified, we default tolocalhostfor backwards compatibility. This may change toos.Hostname()in the future if/when Add gossip protocol for determining node addresses #5672 is implemented.-hostnamecommand-line option back to allow specifying both-joinand-hostnameas command-line flags if desired.Configused by the services and code.joinconfig file option back tometaconfig. This allows join servers to be specified in a config files, via env vars, or command-line flags and ordering precedence is the same as-hostname.Fixes #5669
@corylanou