Improves existing RP checking when creating a DB.

[chris-ramon]

Details

• Currently when running an InfluxQL(CREATE DATABASE IF NOT EXISTS xyz WITH DURATION 24h0m0s REPLICATION 1 NAME one_day_only) to create a database which does not provide shard duration a default value will be set for it via:

  • meta.Data.CreateRetentionPolicy(...) sets a default value (currently 1 hour).

• When re-running the same InfluxQL mentioned above, an error will occur (retention policy conflicts with an existing policy) when it shouldn't, based on the expected behavior of IF NOT EXISTS & confirmed by the docs:

  // Check if the retention policy already exists. If it does and matches
  // the desired retention policy, exit with no error.

  • So current strategy for checking retention policies does not consider the default shard duration value mentioned above.

• TL:DR, this PR improves the checking for existing retention policy within meta.Client.CreateDatabaseWithRetentionPolicy(...) to consider the default shard duration value which is set when none is provided when creating a database.

---

• Rebased/mergable
• Tests pass
• CHANGELOG.md updated
• Sign CLA (if not already signed)

[e-dard]

@chris-ramon thanks for this, looks good. However you'll need to move your CHANGELOG entry to under bugfixes for 0.13. I suggest you rebase from master to get a more recent CHANGELOG.

[chris-ramon]

@chris-ramon thanks for this, looks good. However you'll need to move your CHANGELOG entry to under bugfixes for 0.13. I suggest you rebase from master to get a more recent CHANGELOG.

Hi @fred-influx, thanks for reviewing it! - I've addressed it on 93aa287.

[e-dard]

LGTM 👍