Remove features that were deprecated for 1.0 #6706
Conversation
| @@ -394,6 +385,12 @@ func (e *StatementExecutor) executeSetPasswordUserStatement(q *influxql.SetPassw | |||
| } | |||
|
|
|||
| func (e *StatementExecutor) executeSelectStatement(stmt *influxql.SelectStatement, ctx *influxql.ExecutionContext) error { | |||
| // If there is a target and we are in a read only context, exit early since | |||
| // we will return an error. | |||
| if stmt.Target != nil && ctx.ReadOnly { | |||
There was a problem hiding this comment.
This looks like a breaking change. If it is, I'd rather we leave it as is for backwards compatibility since many clients would need to be updated.
There was a problem hiding this comment.
It is, but so is changing all of the read only stuff from #6290 to now throw an error instead of a warning.
There was a problem hiding this comment.
That's what I'm saying though. It should not throw an error. Removing for 1.0 is not enough time to allow clients to update.
There was a problem hiding this comment.
Removed the commits that remove IF NOT EXISTS and IF EXISTS along with the commit that removes support for using write operations in a read only context. Modified the warning message so it doesn't mention 1.0.
|
Each of these needs release note items in the change log. |
jsternberg
force-pushed
the
js-remove-deprecated-features
branch
2 times, most recently
from
b913112
to
57812dd
Compare
|
👍 |
jsternberg
force-pushed
the
js-remove-deprecated-features
branch
from
57812dd
to
0c3e834
Compare
Removed the version that it would be removed in as we will not be removing it for 1.0.
jsternberg
force-pushed
the
js-remove-deprecated-features
branch
from
0c3e834
to
1518e5e
Compare
|
👍 |
No description provided.