Go version 1.7.4 -> 1.7.5 #7926
Conversation
|
Wondering why only appveyor tested this and not circleci dispite changing things there too!? |
CONTRIBUTING.md
Outdated
| @@ -69,16 +69,16 @@ second to sign our CLA, which can be found | |||
|
|
|||
| Installing Go | |||
| ------------- | |||
| InfluxDB requires Go 1.7.4. | |||
| InfluxDB requires Go 1.7.5. | |||
There was a problem hiding this comment.
I know the wording pre-dates this change, but perhaps we should change it to "recommends" instead.
There was a problem hiding this comment.
Sure! Will change the "requires"
CHANGELOG.md
Outdated
| @@ -7,6 +7,10 @@ | |||
|
|
|||
| ## v1.2.1 [unreleased] | |||
|
|
|||
| ### Features | |||
|
|
|||
| - [#7926](https://github.com/influxdata/influxdb/pulls/7926): Go version 1.7.4 -> 1.7.5 | |||
There was a problem hiding this comment.
Bad url. It's "pull", not "pulls"
|
@phemmer changed both things and rebased it. Tests are running. Can you tell me why the CircleCI Tests do not run here?? |
|
Sorry, didn't mean to give the impression that i'm a maintainer. Just a user who mucks around in the source code a lot :-) |
|
Haha no worries. We'll wait for a maintainer and see, what has to be changed prior to the merge ;-) |
CHANGELOG.md
Outdated
| @@ -7,6 +7,10 @@ | |||
|
|
|||
| ## v1.2.1 [unreleased] | |||
|
|
|||
| ### Features | |||
|
|
|||
| - [#7926](https://github.com/influxdata/influxdb/pull/7926): Go version 1.7.4 -> 1.7.5 | |||
There was a problem hiding this comment.
Can you move this to the 1.3.0 section?
|
@jwilder i've rebased it and moved it to 1.3.0 changes. you can now merge it ;) |
|
Closing this in favor of #8327 |
Required for all non-trivial PRs