Influx CLI: More Connection Warnings #8495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilder
suggested changes
Nov 15, 2017
CHANGELOG.md
Outdated
| @@ -73,6 +73,7 @@ The following new configuration options are available. | |||
| - [#8394](https://github.com/influxdata/influxdb/pull/8394): Optimize top() and bottom() using an incremental aggregator. | |||
| - [#7129](https://github.com/influxdata/influxdb/issues/7129): Maintain the tags of points selected by top() or bottom() when writing the results. | |||
| - [#8188](https://github.com/influxdata/influxdb/issues/8188): Write CQ stats to _internal | |||
| - [#8495](https://github.com/influxdata/influxdb/pull/8495): Improve CLI connection warnings | |||
There was a problem hiding this comment.
Can you move this up to the 1.5 section?
If we don't detect a server version, then there's a good chance that we're not speaking to an InfluxDB server. We should warn the user about this to make it easier for them to debug.
jwilder
approved these changes
Nov 16, 2017
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't detect a server version, then there's a good chance that
we're not speaking to an InfluxDB server. We should warn the user about
this to make it easier for them to debug.
Required for all non-trivial PRs