Do not report an error when dropping a CQ on a non-existent DB/RP #8878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgnorton
requested changes
Sep 26, 2017
There was a problem hiding this comment.
Should also return nil on line 451.
https://github.com/influxdata/influxdb/blob/master/services/meta/data.go#L451
andrewhare
changed the title
ghost
assigned 
|
@andrewhare can you rebase this, remove the changelog update (we're now doing that automatically), and change the line David pointed out? Thanks. |
This makes the behvior similar to other places in the DB where we don't return an error when we try to drop an object from a non- existent database.
jsternberg
changed the title
dgnorton
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the behavior similar to other places in the DB where we
don't return an error when we try to drop an object from a non-
existent database.
Required for all non-trivial PRs