Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct variable style in influxdb.service #8909

Merged
merged 2 commits into from
Oct 3, 2017
Merged

Conversation

mark-rushakoff
Copy link
Contributor

@mark-rushakoff mark-rushakoff commented Oct 3, 2017

From the systemd.service docs:

Use "${FOO}" as part of a word, or as a word of its own, on the command
line, in which case it will be replaced by the value of the environment
variable including all whitespace it contains, resulting in a single
argument. Use "$FOO" as a separate word on the command line, in which
case it will be replaced by the value of the environment variable split
at whitespace, resulting in zero or more arguments.

  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

From the systemd.service docs:

Use "${FOO}" as part of a word, or as a word of its own, on the command
line, in which case it will be replaced by the value of the environment
variable including all whitespace it contains, resulting in a single
argument. Use "$FOO" as a separate word on the command line, in which
case it will be replaced by the value of the environment variable split
at whitespace, resulting in zero or more arguments.
@ghost ghost assigned mark-rushakoff Oct 3, 2017
@ghost ghost added the review label Oct 3, 2017
@mark-rushakoff
Copy link
Contributor Author

Added a Needs Backporting label in case there is a 1.3.7 release.

@mark-rushakoff mark-rushakoff merged commit 6160e36 into master Oct 3, 2017
@ghost ghost removed the review label Oct 3, 2017
@mark-rushakoff mark-rushakoff deleted the mr-service-var branch October 3, 2017 19:59
@mark-rushakoff
Copy link
Contributor Author

Backported in #8910, removing that label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants