telegraf.service remove curly brackets on $TELEGRAF_OPTS #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.freedesktop.org/software/systemd/man/systemd.service.html Basic environment variable substitution is supported. Use "${FOO}" as part of a word, or as a word of its own, on the command line, in which case it will be replaced by the value of the environment variable including all whitespace it contains, resulting in a single argument. Use "$FOO" as a separate word on the command line, in which case it will be replaced by the value of the environment variable split at whitespace, resulting in zero or more arguments. For this type of expansion, quotes are respected when splitting into words, and afterwards removed.
|
heh, this exact same issue came up on InfluxDB just a couple weeks ago: influxdata/influxdb#8909 |
danielnelson
pushed a commit
that referenced
this pull request
Oct 18, 2017
(cherry picked from commit 02baa69)
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the brackets you cannot add more than 1 flag to the ExecStart command. Flags that require arguments will not work.
The following addition to /etc/default/telegraf gives a "flag provided but not defined" ERROR and the service fails to start. Removing the brackets from $TELEGRAF_OPTS fixes this.
#/etc/default/telegraf
TELEGRAF_OPTS=-pidfile /var/run/telegraf/telegraf.pid
log: flag provided but not defined: -pidfile /var/run/telegraf/telegraf.pid
https://www.freedesktop.org/software/systemd/man/systemd.service.html
"Use "${FOO}" as part of a word, or as a word of its own, on the command line, in which case it will be replaced by the value of the environment variable including all whitespace it contains, resulting in a single argument. Use "$FOO" as a separate word on the command line, in which case it will be replaced by the value of the environment variable split at whitespace, resulting in zero or more arguments. "