feat: pull in auth code from Kapacitor Enterprise #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesam
commented
Mar 24, 2021
| ) | ||
|
|
||
| type Config struct { | ||
| Enabled bool `toml:"enabled"` |
There was a problem hiding this comment.
Note Enabled is added
And add a config option to enable it.
docmerlin
reviewed
Mar 24, 2021
docmerlin
approved these changes
Mar 29, 2021
docmerlin
added a commit
that referenced
this pull request
Apr 7, 2021
* feat: add Zenoss event handler (#2484) * feat(kafka): route alerts to partitions by ID, allow for configuring the hashing strategy (#2493) * test: protoc failing on build, skip broken tests (#2506) * fix: Zenoss testing (#2509) * fix: Zenoss testing * test: add missing test * feat: pull in auth code from Kapacitor Enterprise (#2512) And add a config option to enable it. * fix: external Zenoss testability (#2514) * chore: go mod tidy * tests: fix tests and go vet from merge * chore: go fmt * Update Changelog * Update Changelog * Update CHANGELOG.md Co-authored-by: Daniel Moran <danxmoran@gmail.com> * Update CHANGELOG.md Co-authored-by: Daniel Moran <danxmoran@gmail.com> Co-authored-by: alespour <42931850+alespour@users.noreply.github.com> Co-authored-by: Daniel Moran <danxmoran@gmail.com> Co-authored-by: Sam Arnold <sarnold@influxdata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2505
And add a config option to enable it.
Required for all non-trivial PRs