fix: document default Encode behavior #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabigot
force-pushed
the
pabigot/20220101a
branch
from
8c337eb
to
1f6c6e5
Compare
|
Also clarified that this produces records that are terminated by a newline; a strict reading of the specification would allow for newlines appearing only as separators, which if produced would complicate combining encoded batches. |
pabigot
force-pushed
the
pabigot/20220101a
branch
from
1f6c6e5
to
799a310
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current influxdb-client-go provides functions to convert points to line protocol, but it doesn't actually use them, instead delegating to this package. While reviewing how to do the conversion I found that the default behavior of the encoder is not fully specified. This PR clarifies the documentation.