-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add explicit schema bucket APIs #34
Conversation
e229930
to
9c985ad
Compare
@danxmoran / @glinton this is a Cloud 2 only feature at this point. It is possible we could move this to OSS at some later point. My question for you is How would I extend the CLI tools to be able to support this Cloud 2.0 feature? It would include
|
@stuartcarnie I'm pretty sure I wasn't the intended target? Boy, at least I hope so. :) |
Oi! Sorry Dan, I meant to tag @danxmoran |
@stuartcarnie I'd first merge your changes in this branch with the changes in #36, so you're up-to-date with the tweaks needed to make codegen work. After that, I'd add any of the paths+schemas you want the CLI to use into Once you've committed the above, you can:
You'll be the first not-me contributor in the new repo, so please let me know any feedback you have on the codegen flow / process of adding a new command in the new CLI codebase. |
Great info, thanks @danxmoran! I'll work through that today |
I made influxdata/influx-cli#51 to track the work over there |
Are you going to merge #36 today, so I can work of master or should I rebase on that branch? |
Just merged it, you should be set to work off of master |
0dd1aba
to
331ea20
Compare
This commit introduces Cloud 2 specific APIs for managing explicit schema buckets. Most of the changes are in the `cloud` only paths for managing measurement schema. The Bucket type adds a `schemaType` property, that is expected to return `implicit` for OSS 2.x and is not modifiable. For Cloud 2 it can be either `implicit` or `explicit`, once the feature is available.
This allows a client to find a measurement schema within a bucket by name.
76236df
to
4ee3cc2
Compare
This PR introduces Cloud 2 specific APIs for managing explicit schema buckets. Most of the changes are in the
cloud
source tree, as the feature is Cloud 2 only.
The
Bucket
type adds aschemaType
property.implicit
.implicit
orexplicit
, once the feature is available.