Better implementation preventing empty tags

influxdata · Dec 12, 2018 · 048ce7e · 048ce7e
1 parent 925cd8f
commit 048ce7e
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/plugins/outputs/azure_monitor/azure_monitor.go b/plugins/outputs/azure_monitor/azure_monitor.go
@@ -340,6 +340,10 @@ func hashIDWithTagKeysOnly(m telegraf.Metric) uint64 {
 	h.Write([]byte(m.Name()))
 	h.Write([]byte("\n"))
 	for _, tag := range m.TagList() {
+		if tag.Key == "" || tag.Value == "" {
+			continue
+		}
+
 		h.Write([]byte(tag.Key))
 		h.Write([]byte("\n"))
 	}
@@ -359,19 +363,12 @@ func translate(m telegraf.Metric, prefix string) (*azureMonitorMetric, error) {
 			continue
 		}
 
-		var key = tag.Key
-		var value = tag.Value
-
-		if key == "" {
+		if tag.Key == "" || tag.Value == "" {
 			continue
 		}
 
-		if value == "" {
-			value = "<empty>"
-		}
-
-		dimensionNames = append(dimensionNames, key)
-		dimensionValues = append(dimensionValues, value)
+		dimensionNames = append(dimensionNames, tag.Key)
+		dimensionValues = append(dimensionValues, tag.Value)
 	}
 
 	min, err := getFloatField(m, "min")