Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: snmp input non-existing-directory #11122

Closed
powersj opened this issue May 17, 2022 · 1 comment
Closed

test: snmp input non-existing-directory #11122

powersj opened this issue May 17, 2022 · 1 comment
Labels
area/snmp bug unexpected problem or unintended behavior testing request An issue that requires the tests to be updated

Comments

@powersj
Copy link
Contributor

powersj commented May 17, 2022 •
edited
Loading

Relevant telegraf.conf

n/a

Logs from Telegraf

2022/05/17 14:43:11 W! [] No mibs found
2022/05/17 14:43:11 W! [] MIB path doesn't exist: "non-existing-directory"
--- FAIL: TestGosnmpWrapper_walk_retry (0.00s)
    snmp_test.go:563: 
        	Error Trace:	snmp_test.go:563
        	Error:      	Should not be: &net.UDPConn{conn:net.conn{fd:(*net.netFD)(0xc00049ab00)}}
        	Test:       	TestGosnmpWrapper_walk_retry
    snmp_test.go:564: 
        	Error Trace:	snmp_test.go:564
        	Error:      	Not equal: 
        	            	expected: 4
        	            	actual  : 2
        	Test:       	TestGosnmpWrapper_walk_retry
FAIL
FAIL	github.com/influxdata/telegraf/plugins/inputs/snmp	8.655s

System info

master

Docker

No response

Steps to reproduce

  1. go test -count=1 -race ./plugins/inputs/snmp

Expected behavior

test pass

Actual behavior

There are two failures from TestGosnmpWrapper_walk_retry

	assert.NotEqual(t, gs.Conn, conn)
	assert.Equal(t, (gs.Retries+1)*2, reqCount)

Additional info

No response
@powersj powersj added the bug unexpected problem or unintended behavior label May 17, 2022
@powersj
Copy link
Contributor Author

powersj commented May 19, 2022

next steps: look into test failures and determine next steps

powersj added a commit to powersj/telegraf that referenced this issue May 26, 2022
@powersj
test: actually skip flaky snmp test
5feb0d5 
This test had a short skip added to it four years ago and a comment that
the test has random failures. While working on the integration tests,
which run all tests this test started showing up in the errors.

While the two asserts at the end could possibly be updated, it is worth
having someone look deeper into understanding why this change is
required.

In order to get integration tests running, this skips this test always.

fixes: influxdata#11122
@powersj powersj mentioned this issue May 26, 2022
Merged
@Hipska Hipska added the testing request An issue that requires the tests to be updated label Aug 1, 2022
@powersj powersj closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/snmp bug unexpected problem or unintended behavior testing request An issue that requires the tests to be updated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hipska @powersj