Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for mysql gatherGlobalVariables using sql-mock #10036

Closed
wants to merge 3 commits into from

Conversation

fxedel
Copy link
Contributor

@fxedel fxedel commented Oct 31, 2021

Required for all PRs:

See #8561

Add a test that doesn't need a real database connection (by using sql-mock) and asserts proper parsing of the SQL query result.

I already found some issues with the version tag by adding this test, but I'd recommend adding the tests first and fixing the issues afterwards.

Copy link
Contributor

@MyaLongmire MyaLongmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding more tests!

@powersj
Copy link
Contributor

powersj commented Dec 10, 2021

Hi,

Would love to take more tests, however, it looks like the PR tests and lint are failing. Can you take a look at the failures?

Thanks!

@powersj
Copy link
Contributor

powersj commented Mar 28, 2022

@fxedel would you be willing to rebase this PR so we can get this landed? Thanks!

@powersj powersj added the waiting for response waiting for response from contributor label Mar 28, 2022
@telegraf-tiger
Copy link
Contributor

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for response waiting for response from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants