Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysql input plugin needs tests #8561

Closed
reimda opened this issue Dec 14, 2020 · 1 comment · Fixed by #10987
Closed

Mysql input plugin needs tests #8561

reimda opened this issue Dec 14, 2020 · 1 comment · Fixed by #10987
Labels
area/mysql feature request Requests for new plugin and for new features to existing plugins

Comments

@reimda
Copy link
Contributor

reimda commented Dec 14, 2020

Current behavior:

The mysql plugin has very few tests. The existing unit tests cover only narrow parsing tasks. There are a couple integration tests related to connecting. There are no tests related to gathering metrics.

related: #6132

Desired behavior:

Unit tests covering the functionality of the plugin. Include mocking the response from mysql so tests can cover metric generation.

We also need integration tests that check the names and types of values received from mysql. This plugin's fields and field types depend on what it receives from mysql. There have been multiple bugs in telegraf related to the types changing between mysql versions (#5529 #5055). The integration test should check the names and types of fields so we can know when a field type has changed before a user files a bug.

@reimda reimda added the feature request Requests for new plugin and for new features to existing plugins label Dec 14, 2020
@powersj
Copy link
Contributor

powersj commented Mar 28, 2022

next steps: wait for #10036 to land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mysql feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants