-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/jolokia proxy mode #1031
Conversation
code refactor to use same prepareRequest method for both 'agent' and 'proxy' mode
ebc2722
to
a0097ee
Compare
|
||
## List of servers exposing jolokia read service | ||
# This specifies the mode used | ||
# mode = "proxy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the options besides "proxy"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently any value different to "proxy", make the input plugin executing in agent mode.
This looks like a good change to the jolokia plugin, but it is a breaking change as well. Will the POST requests to jolokia work correctly for all users out of the box? |
a0097ee
to
161b946
Compare
POST requests are more powerful and have less escaping issue than GET ones. Yes it is a breaking change in configuration, but it is trivial to change the old 'jmx' with new Mbean/Attribute/Path parts. Would you make it working even after update keeping the old configuration? |
No, I think it's OK if we make it a breaking change. I just wanted to confirm |
@@ -132,37 +226,37 @@ func (j *Jolokia) Gather(acc telegraf.Accumulator) error { | |||
tags["port"] = server.Port |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saiello I should have caught this in the original plugin, but here you are overwriting the telegraf-wide host
tag, could you change these tags:
- server
- port
- host
to:
- server_name
- server_port
- server_host
6d6f36a
to
6de99c5
Compare
@saiello you need to run |
6de99c5
to
12b056c
Compare
thanks @saiello, please rebase your changes and update CHANGELOG.md with this change, as well as writing up something about it being a breaking change under "Release Notes", and then I can merge. Please also ping me when you're done with this, as I don't get notifications on file changes |
this change will now also close #1050 |
it avoid overwriting the telegraf-wide host tag
12b056c
to
5dbd788
Compare
@sparrc I edited the release note. Would you require some kind of "migration guide" in jolokia README? |
@sparrc When this will be merged to master? |
by the end of the week |
Cool. Thank you for the update. |
Added jolokia proxy mode.